Skip to content

Merge v2.0.1 back into dev #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2025
Merged

Merge v2.0.1 back into dev #4001

merged 3 commits into from
Sep 21, 2025

Conversation

jjw24
Copy link
Member

@jjw24 jjw24 commented Sep 21, 2025 •
edited
Loading

Merge v2.0.1 back into dev from master

@jjw24 jjw24 requested a review from Jack251970 September 21, 2025 13:10
@jjw24 jjw24 self-assigned this Sep 21, 2025
@jjw24 jjw24 added the release Release PR which contains the changes going into the upcoming release label Sep 21, 2025
@jjw24 jjw24 marked this pull request as draft September 21, 2025 13:10
@github-actions github-actions bot added this to the 2.1.0 milestone Sep 21, 2025
Jack251970
Jack251970 previously approved these changes Sep 21, 2025
View reviewed changes
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Sep 21, 2025

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2025 •
edited
Loading

📝 Walkthrough

Walkthrough

Removed leading BOM characters from two plugin .csproj files and updated AppVeyor build version from 2.0.0.{build} to 2.0.1.{build}. No functional or public API changes.

Changes

Cohort / File(s) Summary
BOM removal in plugin project files
Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj, Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj		 Removed leading BOM characters; no semantic/project configuration changes.
CI version bump
appveyor.yml		 Updated version string from 2.0.0.{build} to 2.0.1.{build}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • Jack251970

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Merge v2.0.1 back into dev" accurately describes the primary activity in this changeset: merging the v2.0.1 release back into the dev branch. The raw summary shows a version bump in appveyor.yml to 2.0.1.{build} and minor BOM/encoding cleanups in csproj files, which align with a release merge. The title is concise, specific, and meaningful for teammates scanning the commit history.
Description Check ✅ Passed The description "Merge v2.0.1 back into dev from master" is directly related to the changeset and accurately states the action taken, matching the observed version bump and encoding fixes. Although brief, it is on-topic and satisfies the lenient requirements for this check. The description does not need to enumerate file-level details to pass.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch merge_back_v2_0_1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jjw24 jjw24 removed this from the 2.1.0 milestone Sep 21, 2025
@jjw24 jjw24 marked this pull request as ready for review September 21, 2025 13:19
@jjw24 jjw24 enabled auto-merge September 21, 2025 13:19
@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Sep 21, 2025

🥷 Code experts: Jack251970

Jack251970, jjw24 have most 👩‍💻 activity in the files.
jjw24, Jack251970 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj

Activity based on git-commit:

Jack251970 jjw24
SEP 2 additions & 2 deletions
AUG 23 additions & 14 deletions
JUL 1 additions & 1 deletions
JUN 36 additions & 35 deletions
MAY
APR 2 additions & 2 deletions

Knowledge based on git-blame:
Jack251970: 40%
jjw24: 33%

Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj

Activity based on git-commit:

Jack251970 jjw24
SEP 2 additions & 2 deletions
AUG 2 additions & 1 deletions
JUL
JUN 2 additions & 2 deletions
MAY
APR

Knowledge based on git-blame:
jjw24: 17%
Jack251970: 4%

appveyor.yml

Activity based on git-commit:

Jack251970 jjw24
SEP
AUG 1 additions & 1 deletions
JUL 1 additions & 1 deletions
JUN 5 additions & 3 deletions
MAY 11 additions & 10 deletions
APR

Knowledge based on git-blame:
jjw24: 36%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@jjw24 jjw24 requested a review from Jack251970 September 21, 2025 13:20
coderabbitai[bot]
coderabbitai bot reviewed Sep 21, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj (1)

1-1: BOM removal — LGTM.

Nice consistency with Calculator plugin project.

Consider enforcing UTF‑8 without BOM via .editorconfig to prevent regressions:

[*.csproj]
charset = utf-8
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35867a0 and dc1f0f1.

📒 Files selected for processing (3)
  • Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj (1 hunks)
  • Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj (1 hunks)
  • appveyor.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-08T15:52:58.573Z 
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-10-08T15:52:58.573Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.

Applied to files:

  • Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: build
🔇 Additional comments (1)
appveyor.yml (1)

1-1: Version bump to 2.0.1 — LGTM.

APPVEYOR_BUILD_VERSION like 2.0.1.x parses to Major=2, Minor=0, Build=1, Revision=x, so $(flowVersion) resolves to 2.0.1 and $(prereleaseTag) to 2.0.1.x on dev — as intended.

Please confirm the AppVeyor "Visual Studio 2022" image has .NET 9 SDK available so the build still succeeds after this back-merge.

@jjw24 jjw24 merged commit 7de420e into dev Sep 21, 2025
15 checks passed
@jjw24 jjw24 deleted the merge_back_v2_0_1 branch September 21, 2025 13:32
TBM13 pushed a commit to TBM13/Flow.Launcher that referenced this pull request Sep 23, 2025
@jjw24 @TBM13
Merge pull request Flow-Launcher#4001 from Flow-Launcher/merge_back_v…
d825c80 
…2_0_1

Merge v2.0.1 back into dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Jack251970 Jack251970 Jack251970 approved these changes

Assignees

@jjw24 jjw24

Labels
release Release PR which contains the changes going into the upcoming release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjw24 @Jack251970